Skip to content

Commit

Permalink
chore: update chromedriver to 121 (#1005)
Browse files Browse the repository at this point in the history
* chore: update chromedriver to 121

* update pin

* update chrome browser name

* chrome

* fix test
  • Loading branch information
michael-siek authored Feb 6, 2024
1 parent 38e440c commit 04b0f1b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- run: npm ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver=119 --verbose
run: npx browser-driver-manager install chromedriver=121 --verbose
working-directory: packages/cli
- run: npm run coverage --workspace=packages/cli

Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/cli/src/lib/webdriver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ describe('startDriver', () => {
browser = 'chrome-headless';
driver = await startDriver(config);
const capabilities = await driver.getCapabilities();

assert.equal(capabilities.get('browserName'), 'chrome');
// https://github.com/seleniumbase/SeleniumBase/issues/2343\
assert.include(capabilities.get('browserName'), 'chrome');
});

it('uses the chromedriver path with chrome-headless', async () => {
Expand Down

0 comments on commit 04b0f1b

Please sign in to comment.