You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe. #5001 added support for scanning Maven plugins. However, as pointed out in jeremylong/DependencyCheck#4035 (comment) Dependency Check currently considers all dependencies of plugins, including provided ones which are actually provided by the Maven installation and are therefore mostly irrelevant for checking vulnerabilities.
This renders the <scanPlugins> feature a bit useless because plugins often try to support old Maven versions (and therefore potentially vulnerable old provided dependencies) which leads to false positives.
Describe the solution you'd like
Either:
<scanPlugins> should respect the existing <skipProvidedScope> option (and possibly other options as well?)
or there should be a new dedicated option to exclude provided dependencies of plugins
or Dependency Check should ignore provided dependencies of plugins by default
Describe alternatives you've considered See bullet points above
Additional context
Even though as mentioned in jeremylong/DependencyCheck#4035 (comment) the Maven Dependency Plugin currently behaves the same way (which might also be a bug there), Dependency Check does not necessarily have to stick to that behavior (unless there are of course technical limitations) because the use case for Dependency Check is quite different.
Run mvn verify
❌ Issue: It shows a lot of vulnerabilities, including for example multiple for maven-core-3.1.0.jar, even though that is a provided dependency
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
#5001 added support for scanning Maven plugins. However, as pointed out in jeremylong/DependencyCheck#4035 (comment) Dependency Check currently considers all dependencies of plugins, including
provided
ones which are actually provided by the Maven installation and are therefore mostly irrelevant for checking vulnerabilities.This renders the
<scanPlugins>
feature a bit useless because plugins often try to support old Maven versions (and therefore potentially vulnerable oldprovided
dependencies) which leads to false positives.Describe the solution you'd like
Either:
<scanPlugins>
should respect the existing<skipProvidedScope>
option (and possibly other options as well?)provided
dependencies of pluginsprovided
dependencies of plugins by defaultDescribe alternatives you've considered
See bullet points above
Additional context
Even though as mentioned in jeremylong/DependencyCheck#4035 (comment) the Maven Dependency Plugin currently behaves the same way (which might also be a bug there), Dependency Check does not necessarily have to stick to that behavior (unless there are of course technical limitations) because the use case for Dependency Check is quite different.
Reproduction steps
pom.xml
with the following contentmvn verify
❌ Issue: It shows a lot of vulnerabilities, including for example multiple for
maven-core-3.1.0.jar
, even though that is aprovided
dependencyThe text was updated successfully, but these errors were encountered: