Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Skipped GitHub Actions jobs prevent automatic merging of PRs #910

Closed
scothis opened this issue Apr 14, 2020 · 4 comments
Closed

Skipped GitHub Actions jobs prevent automatic merging of PRs #910

scothis opened this issue Apr 14, 2020 · 4 comments
Labels
T: bug 🐞 Something isn't working

Comments

@scothis
Copy link

scothis commented Apr 14, 2020

We've been happily using Dependabot's auto merge capability after CI has passed and the PR is approved. GitHub Actions recently started to report the status of jobs that were conditionally skipped for the workflow. PRs with these skipped jobs no longer automatically merge.

For example, this PR is approved and CI passed, but it has not merged:

projectriff/builder#303

(note that I manually merged after 4 days where Dependabot should have merged)

Other PRs without skipped jobs continue to merge as expected:

projectriff/streaming-http-adapter#45

@scothis scothis added the T: bug 🐞 Something isn't working label Apr 14, 2020
@AlCalzone
Copy link

I've wondered about this aswell. Here's an example where even a merge comment doesn't do anything:
grafik

@tsimbalar
Copy link

We have observed this behavior as well in our organization.

It seems to have started at the very end of the month of April , when "automatic PR review assigment" finally started to work for dependabot's PRs , but telling "squash and merge" would not merge the PR.

@tsimbalar
Copy link

Just to link issues together, this seem to be similar to #948 as well

@feelepxyz
Copy link
Contributor

Pushed a fix for merging/automerging when there are skipped check runs. Rolling out fix for both versions of Dependabot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants