Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable YJIT #9633

Open
JamieMagee opened this issue Apr 29, 2024 · 4 comments
Open

Enable YJIT #9633

JamieMagee opened this issue Apr 29, 2024 · 4 comments
Labels

Comments

@JamieMagee
Copy link
Contributor

Code improvement description

Once #9597 is complete, we should enable YJIT and monitor the performance.

References:

@JamieMagee
Copy link
Contributor Author

@landongrindheim is there enough data to decide whether or not to enable YJIT globally?

@landongrindheim
Copy link
Member

@JamieMagee Thanks for checking in on this! Here's a graph tracking job durations (the thing we were specifically hoping to impact) 👇 I don't think there's an appreciable difference, though the max values are 🤏 improved. I suspect YJIT would make a bigger difference for longer-running processes.

Image


Here's a split view of the same data, in case the overlay is hard to read.

Image

@JamieMagee
Copy link
Contributor Author

@landongrindheim thanks for the update. If that's kusto, could you regenerate the graphs with percentiles instead of avg. That should better show if the max values are improving.

I'd recommend using the 68-95-99.7 rule to show 1, 2, and 3 standard deviations from the mean i.e. summarize percentiles(..., 68, 95, 99.7) by yjit_enabled

@landongrindheim
Copy link
Member

It's Datadog. And I wrote that before thinking about what it was actually reporting 🤦 The max would be the timing of an individual job, which isn't especially meaningful in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants