From c9283fc79c022b3c95ec5d39598ba5cfce9786d7 Mon Sep 17 00:00:00 2001
From: raj-meka <166544023+raj-meka@users.noreply.github.com>
Date: Thu, 13 Jun 2024 12:07:53 -0400
Subject: [PATCH] Strict type Dependabot::Hex::FileParser.

---
 hex/lib/dependabot/hex/file_parser.rb | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/hex/lib/dependabot/hex/file_parser.rb b/hex/lib/dependabot/hex/file_parser.rb
index 9c14fee76e..f575b744d8 100644
--- a/hex/lib/dependabot/hex/file_parser.rb
+++ b/hex/lib/dependabot/hex/file_parser.rb
@@ -1,6 +1,7 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
+require "sorbet-runtime"
 require "dependabot/dependency"
 require "dependabot/file_parsers"
 require "dependabot/file_parsers/base"
@@ -13,8 +14,10 @@
 module Dependabot
   module Hex
     class FileParser < Dependabot::FileParsers::Base
+      extend T::Sig
       require "dependabot/file_parsers/base/dependency_set"
 
+      sig { override.returns(T::Array[Dependabot::Dependency]) }
       def parse
         # TODO: git sourced dependency's mixfiles are evaluated. Provide guards before removing this.
         raise ::Dependabot::UnexpectedExternalCode if @reject_external_code
@@ -43,11 +46,12 @@ def parse
 
       private
 
+      sig { returns(T::Array[T.any(T::Hash[String, String], T::Hash[String, T.untyped])]) }
       def dependency_details
         SharedHelpers.in_a_temporary_directory do
           write_sanitized_mixfiles
           write_sanitized_supporting_files
-          File.write("mix.lock", lockfile.content) if lockfile
+          File.write("mix.lock", lockfile&.content) if lockfile
           FileUtils.cp(elixir_helper_parse_deps_path, "parse_deps.exs")
 
           SharedHelpers.run_helper_subprocess(
@@ -69,28 +73,32 @@ def dependency_details
         JSON.parse(result_json).fetch("result")
       end
 
+      sig { void }
       def write_sanitized_mixfiles
         mixfiles.each do |file|
           path = file.name
           FileUtils.mkdir_p(Pathname.new(path).dirname)
-          File.write(path, sanitize_mixfile(file.content))
+          File.write(path, sanitize_mixfile(T.must(file.content)))
         end
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def write_sanitized_supporting_files
         dependency_files.select(&:support_file).each do |file|
           path = file.name
           FileUtils.mkdir_p(Pathname.new(path).dirname)
-          File.write(path, sanitize_mixfile(file.content))
+          File.write(path, sanitize_mixfile(T.must(file.content)))
         end
       end
 
+      sig { params(content: String).returns(String) }
       def sanitize_mixfile(content)
         Hex::FileUpdater::MixfileSanitizer.new(
           mixfile_content: content
         ).sanitized_content
       end
 
+      sig { returns(T::Hash[String, String]) }
       def mix_env
         {
           "MIX_EXS" => File.join(NativeHelpers.hex_helpers_dir, "mix.exs"),
@@ -100,28 +108,34 @@ def mix_env
         }
       end
 
+      sig { returns(String) }
       def elixir_helper_path
         File.join(NativeHelpers.hex_helpers_dir, "lib/run.exs")
       end
 
+      sig { returns(String) }
       def elixir_helper_parse_deps_path
         File.join(NativeHelpers.hex_helpers_dir, "lib/parse_deps.exs")
       end
 
+      sig { override.void }
       def check_required_files
         raise "No mixfile!" if mixfiles.none?
       end
 
+      sig { params(hash: T::Hash[String, String]).returns(T::Hash[Symbol, T.nilable(String)]) }
       def symbolize_keys(hash)
         hash.keys.to_h { |k| [k.to_sym, hash[k]] }
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def mixfiles
         dependency_files.select { |f| f.name.end_with?("mix.exs") }
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def lockfile
-        @lockfile ||= get_original_file("mix.lock")
+        @lockfile ||= T.let(get_original_file("mix.lock"), T.nilable(Dependabot::DependencyFile))
       end
     end
   end