diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cb98739b8f..93b0dcc6cb 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -55,7 +55,6 @@ RSpec/ContextWording: - 'composer/**/*' - 'devcontainers/**/*' - 'docker/**/*' - - 'git_submodules/**/*' - 'github_actions/**/*' - 'go_modules/**/*' - 'gradle/**/*' diff --git a/git_submodules/spec/dependabot/git_submodules/file_fetcher_spec.rb b/git_submodules/spec/dependabot/git_submodules/file_fetcher_spec.rb index 105b2839c1..f475fd6073 100644 --- a/git_submodules/spec/dependabot/git_submodules/file_fetcher_spec.rb +++ b/git_submodules/spec/dependabot/git_submodules/file_fetcher_spec.rb @@ -52,7 +52,7 @@ ) end - context "that are fetchable" do + context "when dealing with a fetchable path" do before do stub_request(:get, url + "about/documents?ref=sha") .with(headers: { "Authorization" => "token token" }) @@ -88,7 +88,7 @@ end end - context "that has an unfetchable path" do + context "when dealing with an unfetchable path" do before do stub_request(:get, url + "about/documents?ref=sha") .with(headers: { "Authorization" => "token token" }) @@ -104,7 +104,7 @@ end end - context "that has a path that returns a file" do + context "when the path returns a file" do before do stub_request(:get, url + "about/documents?ref=sha") .with(headers: { "Authorization" => "token token" }) @@ -128,7 +128,7 @@ end end - context "that has a path that returns a repo" do + context "when the path returns a repo" do before do stub_request(:get, url + "about/documents?ref=sha") .with(headers: { "Authorization" => "token token" }) @@ -174,7 +174,7 @@ ) end - context "that are fetchable" do + context "when dealing with a fetchable path" do before do stub_request(:get, url + "about%2Fdocuments?ref=sha") .to_return( @@ -208,7 +208,7 @@ end end - context "that has an unfetchable path" do + context "when dealing with an unfetchable path" do before do stub_request(:get, url + "about%2Fdocuments?ref=sha") .to_return( diff --git a/git_submodules/spec/dependabot/git_submodules/update_checker_spec.rb b/git_submodules/spec/dependabot/git_submodules/update_checker_spec.rb index 979abd9424..79fbb1174f 100644 --- a/git_submodules/spec/dependabot/git_submodules/update_checker_spec.rb +++ b/git_submodules/spec/dependabot/git_submodules/update_checker_spec.rb @@ -42,13 +42,13 @@ describe "#can_update?" do subject { checker.can_update?(requirements_to_unlock: :own) } - context "given an outdated dependency" do + context "when dealing with an outdated dependency" do before { allow(checker).to receive(:latest_version).and_return("sha2") } it { is_expected.to be_truthy } end - context "given an up-to-date dependency" do + context "when dealing with an up-to-date dependency" do before do allow(checker) .to receive(:latest_version)