Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CI): pin runner to macOS-12 #3261

Merged
merged 1 commit into from
Mar 17, 2023
Merged

refactor(CI): pin runner to macOS-12 #3261

merged 1 commit into from
Mar 17, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 17, 2023

For the same reason that Ubuntu and Windows runner versions are pinned.

@iuioiua iuioiua marked this pull request as ready for review March 17, 2023 03:16
@iuioiua iuioiua requested a review from kt3k as a code owner March 17, 2023 03:16
@lino-levan
Copy link
Contributor

I'm curious on what the reasoning was for pinning the versions of the other runners?

@kt3k
Copy link
Member

kt3k commented Mar 17, 2023

denoland/deno uses explicit version number since denoland/deno#6884 and this looks like the reasoning for it. I agree with it. Let's use the explicit version

kt3k
kt3k approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 3e98ac2 into denoland:main Mar 17, 2023
@iuioiua iuioiua deleted the macos-12 branch March 17, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @lino-levan @kt3k