From 4caba864223ba953778633697cea9e75f71eb6d4 Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Fri, 10 Jan 2025 15:49:06 +0900 Subject: [PATCH] chore: misc clean up --- .github/workflows/ci.yml | 3 --- _tools/node_test_runner/package.json | 3 +++ deno.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 842f871f02f7..88be898684d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -97,9 +97,6 @@ jobs: with: node-version: ${{ matrix.node }} - - run: npm install - working-directory: _tools/node_test_runner - - name: Run tests run: deno task test:node diff --git a/_tools/node_test_runner/package.json b/_tools/node_test_runner/package.json index 062d06077a30..cef31b5e362d 100644 --- a/_tools/node_test_runner/package.json +++ b/_tools/node_test_runner/package.json @@ -3,5 +3,8 @@ "private": true, "dependencies": { "@deno/shim-deno-test": "^0.5.0" + }, + "engines": { + "node": ">=23.6.0" } } diff --git a/deno.json b/deno.json index 09a08bc0e375..54db28f199a4 100644 --- a/deno.json +++ b/deno.json @@ -10,7 +10,7 @@ "tasks": { "test": "deno test --unstable-http --unstable-webgpu --doc --allow-all --parallel --coverage --trace-leaks --clean", "test:browser": "git grep --name-only \"This module is browser compatible.\" | grep -v deno.json | grep -v .github/workflows | grep -v _tools | grep -v encoding/README.md | grep -v media_types/vendor/update.ts | xargs deno check --config browser-compat.tsconfig.json", - "test:node": "node --import ./_tools/node_test_runner/register_deno_shim.mjs ./_tools/node_test_runner/run_test.mjs", + "test:node": "(cd _tools/node_test_runner && npm install) && node --import ./_tools/node_test_runner/register_deno_shim.mjs ./_tools/node_test_runner/run_test.mjs", "fmt:licence-headers": "deno run --allow-read --allow-write ./_tools/check_licence.ts", "lint:deprecations": "deno run --allow-read --allow-net --allow-env ./_tools/check_deprecation.ts", "lint:circular": "deno run --allow-env --allow-read --allow-write --allow-net=deno.land,jsr.io ./_tools/check_circular_package_dependencies.ts",