From d58fce5fa4a044811bd1b13b7d2e4b6fdecfef8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 3 Nov 2023 15:46:36 +0100 Subject: [PATCH 1/2] fix(doc): require source files if --html or --lint used --- cli/args/flags.rs | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/cli/args/flags.rs b/cli/args/flags.rs index fa1534e0c73674..31dd4f1a51b2a9 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -1480,7 +1480,8 @@ Show documentation for runtime built-ins: Arg::new("source_file") .num_args(1..) .action(ArgAction::Append) - .value_hint(ValueHint::FilePath), + .value_hint(ValueHint::FilePath) + .required_if_eq_any([("html", "true"), ("lint", "true")]), ) }) } @@ -7541,6 +7542,15 @@ mod tests { } ); + let r = flags_from_vec(svec![ + "deno", + "doc", + "--html", + "--name=My library", + "--lint", + ]); + assert!(r.is_err()); + let r = flags_from_vec(svec![ "deno", "doc", @@ -7677,6 +7687,9 @@ mod tests { } ); + let r = flags_from_vec(svec!["deno", "doc", "--lint",]); + assert!(r.is_err()); + let r = flags_from_vec(svec![ "deno", "doc", From 050608d48a2768f7de0a0ec00b5cf94539b110ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 3 Nov 2023 15:48:35 +0100 Subject: [PATCH 2/2] update test --- cli/args/flags.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cli/args/flags.rs b/cli/args/flags.rs index 31dd4f1a51b2a9..82a536e4763b3c 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -7542,13 +7542,8 @@ mod tests { } ); - let r = flags_from_vec(svec![ - "deno", - "doc", - "--html", - "--name=My library", - "--lint", - ]); + let r = + flags_from_vec(svec!["deno", "doc", "--html", "--name=My library",]); assert!(r.is_err()); let r = flags_from_vec(svec![