From c86ef6e283e5f7cc9d747b880808ebf789510e3b Mon Sep 17 00:00:00 2001 From: Trevor Manz Date: Thu, 5 Oct 2023 16:28:05 -0400 Subject: [PATCH 1/3] fix(jupyter): Rename logo assets so they are discoverable --- cli/tools/jupyter/install.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/tools/jupyter/install.rs b/cli/tools/jupyter/install.rs index d1777d92d5f196..c1bace0a6c3a4a 100644 --- a/cli/tools/jupyter/install.rs +++ b/cli/tools/jupyter/install.rs @@ -61,8 +61,8 @@ pub fn install() -> Result<(), AnyError> { let f = std::fs::File::create(kernel_json_path)?; serde_json::to_writer_pretty(f, &json_data)?; - install_icon(temp_dir.path(), "icon-32x32.png", DENO_ICON_32)?; - install_icon(temp_dir.path(), "icon-64x64.png", DENO_ICON_64)?; + install_icon(temp_dir.path(), "logo-32x32.png", DENO_ICON_32)?; + install_icon(temp_dir.path(), "logo-64x64.png", DENO_ICON_64)?; let child_result = std::process::Command::new("jupyter") .args([ From a8420b99ddd5a0f973d3f203020f4c7dcc345a8f Mon Sep 17 00:00:00 2001 From: Trevor Manz Date: Thu, 5 Oct 2023 16:48:38 -0400 Subject: [PATCH 2/3] feat: add logo from wikipedia --- cli/tools/jupyter/install.rs | 2 ++ cli/tools/jupyter/resources/deno-logo-svg.svg | 1 + 2 files changed, 3 insertions(+) create mode 100644 cli/tools/jupyter/resources/deno-logo-svg.svg diff --git a/cli/tools/jupyter/install.rs b/cli/tools/jupyter/install.rs index c1bace0a6c3a4a..d1e4ef46b62036 100644 --- a/cli/tools/jupyter/install.rs +++ b/cli/tools/jupyter/install.rs @@ -12,6 +12,7 @@ use tempfile::TempDir; const DENO_ICON_32: &[u8] = include_bytes!("./resources/deno-logo-32x32.png"); const DENO_ICON_64: &[u8] = include_bytes!("./resources/deno-logo-64x64.png"); +const DENO_ICON_SVG: &[u8] = include_bytes!("./resources/deno-logo-svg.svg"); pub fn status() -> Result<(), AnyError> { let output = std::process::Command::new("jupyter") @@ -63,6 +64,7 @@ pub fn install() -> Result<(), AnyError> { serde_json::to_writer_pretty(f, &json_data)?; install_icon(temp_dir.path(), "logo-32x32.png", DENO_ICON_32)?; install_icon(temp_dir.path(), "logo-64x64.png", DENO_ICON_64)?; + install_icon(temp_dir.path(), "logo-svg.svg", DENO_ICON_SVG)?; let child_result = std::process::Command::new("jupyter") .args([ diff --git a/cli/tools/jupyter/resources/deno-logo-svg.svg b/cli/tools/jupyter/resources/deno-logo-svg.svg new file mode 100644 index 00000000000000..f87ef30e93080e --- /dev/null +++ b/cli/tools/jupyter/resources/deno-logo-svg.svg @@ -0,0 +1 @@ +Deno logo \ No newline at end of file From a308c4a1b672e9b96e80d1b1a14b181627baeebe Mon Sep 17 00:00:00 2001 From: Trevor Manz Date: Thu, 5 Oct 2023 19:35:57 -0400 Subject: [PATCH 3/3] use svg from deno.com --- cli/tools/jupyter/resources/deno-logo-svg.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/tools/jupyter/resources/deno-logo-svg.svg b/cli/tools/jupyter/resources/deno-logo-svg.svg index f87ef30e93080e..d7bb9ef804f33d 100644 --- a/cli/tools/jupyter/resources/deno-logo-svg.svg +++ b/cli/tools/jupyter/resources/deno-logo-svg.svg @@ -1 +1 @@ -Deno logo \ No newline at end of file +