Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement net.Socket#ref for TTY handles #21216

Open
ulken opened this issue Nov 15, 2023 · 0 comments
Open

Implement net.Socket#ref for TTY handles #21216

ulken opened this issue Nov 15, 2023 · 0 comments
Labels
node API Related to various "node:*" modules APIs node compat

Comments

@ulken
Copy link

ulken commented Nov 15, 2023

I'm trying to use useStdin() in term.ink but it crashes with:

  ERROR  unreachable

 ext:deno_node/_util/asserts.ts:16:9

 - unreachable (ext:deno_node/_util/asserts.ts:16:9)
 - TTY.ref (ext:deno_node/internal_binding/handle_wrap.ts:38:5)
 - ReadStream.ref (node:net:658:20)
 ...

More specifically, it fails here.

The problem seems to be ref() not being implemented in net.Socket. Being new to Deno, the documentation confuses me, since std / node / net.ts > Socket#ref suggests that it's indeed implemented?


Reference: #20855 (comment)

@bartlomieju bartlomieju added the node API Related to various "node:*" modules APIs label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node API Related to various "node:*" modules APIs node compat
Projects
None yet
Development

No branches or pull requests

3 participants