Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: notify client when config file is auto-discovered #13552

Closed
kitsonk opened this issue Jan 31, 2022 · 1 comment
Closed

lsp: notify client when config file is auto-discovered #13552

kitsonk opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Jan 31, 2022

In order to be able to provide "auto-enablement" of Deno projects with the language server when a config file is auto-discovered, the language server would need to search the workspace and notify the client when a deno.jsonc file is auto-discovered as well as have semantics for being "enabled" when that occurs (but respecting explicit configuration of not-being enabled).

The biggest challenge is the explicit enablement/disablement, as we can't really disambiguate that at the moment. The specific case which I don't think we can currently handle is that there is a deno.jsonc in the workspace root, but the user has for whatever reason, explicitly set it as "deno.enable": false versus that being the default value.

Ref: denoland/vscode_deno#617

@kitsonk kitsonk added the feat new feature (which has been agreed to/accepted) label Jan 31, 2022
@kitsonk kitsonk added this to the 1.19.0 milestone Jan 31, 2022
@lucacasonato lucacasonato added the lsp related to the language server label Feb 4, 2022
@kitsonk kitsonk modified the milestones: 1.19.0, 1.21 Mar 25, 2022
@kitsonk kitsonk self-assigned this Mar 25, 2022
@kitsonk kitsonk modified the milestones: 1.21, 1.22 Apr 25, 2022
@kitsonk kitsonk removed this from the 1.22 milestone Sep 29, 2022
@nayeemrmn
Copy link
Collaborator

Closed by #20827.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Development

No branches or pull requests

3 participants