Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ascii diagrams with Windows line-endings #7

Open
demurgos opened this issue May 11, 2019 · 2 comments
Open

Fix ascii diagrams with Windows line-endings #7

demurgos opened this issue May 11, 2019 · 2 comments

Comments

@demurgos
Copy link
Owner

demurgos commented May 11, 2019

@bcoe reported having issues on Windows due to the ascii range diagrams, possibly related to Windows line endings.

Some regexes are using dotAll mode (/s) when it's not needed, but I think that the core issue is related to how the lines are split. To mitigate the issue, I'll add an editorconfig file enforcing lf line endings, remove the extra /s and fix line splitting.

@bcoe
Copy link
Collaborator

bcoe commented May 13, 2019

@demurgos it wasn't ultimately a Windows issue, we had an older version of Node 8 in our Windows CI that I don't believe yet supported /s, just an FYI.

@demurgos
Copy link
Owner Author

Thanks for the clarification. I cleaned up the code slightly and found no link with line endings. Your explanation makes sense (I removed the dotAll flag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants