Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to crates.io? #69

Open
bartlomieju opened this issue Jan 11, 2022 · 5 comments
Open

Publish to crates.io? #69

bartlomieju opened this issue Jan 11, 2022 · 5 comments

Comments

@bartlomieju
Copy link

Hi!

I wanted to use v8-coverage in Deno, where we're having some problems with reported coverage (turns out we don't merge ranges properly 🙃); however I'm unable to locate the crate on crates.io.

Do you plan to publish it in near future?

@bartlomieju
Copy link
Author

Tangentially, if the crate could be published to crates.io; would you accept a PR that moves rayon dependency behind a feature flag?

@demurgos
Copy link
Owner

demurgos commented Feb 6, 2022

@bartlomieju Sorry for the long delay.

I plan on cleaning up this repo and publishing everything, but I recently had a new job and it's harder to find time to work on it. I'll try to advance as best as I can this month.

I agree, I'll move rayon into a feature flag.

@bartlomieju
Copy link
Author

@demurgos thanks for response; for now I just forked and code and put it directly into our codebase; it's working great! Let me know if you need any help with it.

@demurgos
Copy link
Owner

demurgos commented Feb 6, 2022

No problem :)

You should still be warned that the Rust version was less tested than the TypeScript one. The TypeScript version is widely used by c8 and jest on the Node side, but I am not sure if the Rust code is up-to-date.

My immediate goal is to share the tests between the Rust and TypeScript implementations to make sure both codebases agree. Once same tests pass on both sides, I'll publish an initial version to crates.io.

@bartlomieju
Copy link
Author

Sounds good, having a unified test suite would definitely be a benefit! Looking forward to a release to crates.io, your library saved me a lot of headaches :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants