diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4067818f9f..25d332fc73 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,6 @@ -- [ ] Breaking changes enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053) -- [ ] New documentation enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053) -- [ ] Code has been declaratized -- [ ] Error handling beautiful (no unwraps or expects etc) -- [ ] Code tested thoroughly +- [ ] Breaking changes enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053) +- [ ] New documentation enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053) +- [ ] Code has been declaratized +- [ ] Error handling beautiful (no unwraps or expects etc) +- [ ] Code tested thoroughly +- [ ] All new functions have JSDoc/Rustdoc comments diff --git a/.github/workflows/pr_tasks_check.yml b/.github/workflows/pr_tasks_check.yml index fe96466329..81b2350bc9 100644 --- a/.github/workflows/pr_tasks_check.yml +++ b/.github/workflows/pr_tasks_check.yml @@ -13,6 +13,7 @@ jobs: pr_tasks_check: name: All PR checkboxes marked completed runs-on: ubuntu-latest + if: github.event.pull_request.draft == false steps: - uses: actions/checkout@v4 diff --git a/test/property/arbitraries/candid/constructed/opt_arb/index.ts b/test/property/arbitraries/candid/constructed/opt_arb/index.ts index af3ad6b028..5b3d0fcab3 100644 --- a/test/property/arbitraries/candid/constructed/opt_arb/index.ts +++ b/test/property/arbitraries/candid/constructed/opt_arb/index.ts @@ -17,7 +17,7 @@ export function OptArb( ): fc.Arbitrary> { const definitionContext = { ...context, - constraints: { depthLevel: DEFAULT_DEFINITION_MAX_DEPTH } + constraints: { depthLevel: DEFAULT_DEFINITION_MAX_DEPTH - 1 } }; return CandidValueAndMetaArbGenerator( context,