Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Starlight 0.32 #185

Open
oluwatobiss opened this issue Feb 18, 2025 · 2 comments
Open

Support Starlight 0.32 #185

oluwatobiss opened this issue Feb 18, 2025 · 2 comments
Labels
needs reproduction Issues that need a minimal reproduction in order to debug

Comments

@oluwatobiss
Copy link

The plugin stops working after upgrading from Starlight v0.31.1 to v0.32.0. This is probably because Starlight now accesses the current route's data object via Astro.locals.starlightRoute rather than Astro.props, which was used in the previous version.

@delucis
Copy link
Owner

delucis commented Feb 18, 2025

Hmm, could you share a reproduction? This package is not specific to Starlight and doesn’t need to access the route data object.

@delucis delucis added the needs reproduction Issues that need a minimal reproduction in order to debug label Feb 18, 2025
@oluwatobiss
Copy link
Author

This is a very strange one—the conflict seems to be between Astro Embed 0.9.0 and Starlight Blog 0.17.2's CSS.

The plugin works without Starlight Blog:

Astro embed works without Starlight blog

However, only the Play text shows when Starlight Blog is installed.

Astro embed with Starlight blog shows only a play text

Here's the reproduction:

https://github.com/oluwatobiss/astro-embed-issue-185-reproduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction Issues that need a minimal reproduction in order to debug
Projects
None yet
Development

No branches or pull requests

2 participants