[fix] odemisd: handle metadata for monochromator with both spectrograph and filter #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ph and filter With a monochromator, both the filter (in front of the spectrograph), and the spectrograph center wavelength + output slit opening have effect on which wavelength is observed. Until now, move on any of the axes would update MD_OUT_WL... but only the latest move would define the value. That's especially annoying if the lastest move is to move the filter to "pass-through" (very common). In this case, the MD_OUT_WL would be empty (incorrectly). The right way to compute MD_OUT_WL is to take into account all the axes together. Essentially, taking the intersection between the filter wavelength range and the output slit opening range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a monochromator, both the filter (in front of the spectrograph),
and the spectrograph center wavelength + output slit opening have effect
on which wavelength is observed. Until now, move on any of the axes
would update MD_OUT_WL... but only the latest move would define the
value.
That's especially annoying if the lastest move is to move the filter to
"pass-through" (very common). In this case, the MD_OUT_WL would be empty
(incorrectly).
The right way to compute MD_OUT_WL is to take into account all the axes
together. Essentially, taking the intersection between the filter
wavelength range and the output slit opening range.