[SDEV-1958] extend tiled acquisition code to be able to acquire non rectangular shapes #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepals
requested changes
Jan 28, 2025
|
|
||
| # We have a little bit more tiles than needed, we then have two choices | ||
| # on how to spread them: | ||
| # 1. Increase the total area acquired (and keep the overlap) | ||
| # 2. Increase the overlap (and keep the total area) | ||
| # We pick alternative 1 (no real reason) | ||
| center = (self._area[0] + self._area[2]) / 2, (self._area[1] + self._area[3]) / 2 | ||
| xmin, ymin, xmax, ymax = self._polygon.bounds | ||
| center = ((xmin + xmax) / 2, (ymin + ymax) / 2) | ||
| total_size = nx * reliable_fov[0], ny * reliable_fov[1] |
There was a problem hiding this comment.
Not completely sure if it matters here, but the total size should include one overlap as well. Since for the total width you have one full tile and (n-1) overlapping tiles
Suggested change
| total_size = nx * reliable_fov[0], ny * reliable_fov[1] | |
| total_size = nx * reliable_fov[0] + self._sfov[0] * self._overlap, | |
| ny * reliable_fov[1] + self._sfov[1] * self._overlap |
There was a problem hiding this comment.
I am also not sure here. @pieleric can you help?
b06b67a to
3012770
Compare
…ther be a bounding box or points
…a region which can either be a bounding box or points
3012770 to
65891b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes are similar to that of FASTEM ROA which is represented by points. One difference is that
TiledAcquisitionTasksupports both a bound box and points as an input region and is backwards compatible.Attached an image for overview image acquisition of a rotated rectangle
