[refactor] [METEOR-1186] CryoFeature Refactor #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teor-960-feature-refactor
K4rishma
reviewed
Feb 3, 2025
|
I'm waiting with the review once the dependencies are merged, if that's okay with you. |
K4rishma
approved these changes
Feb 4, 2025
| @@ -128,9 +140,11 @@ def on_dbl_click(self, evt): | |||
| v_pos = evt.Position | |||
There was a problem hiding this comment.
@nandishjpatel found that error with self.active. Coming back to the question, The thing is self.active.value is always set to True, it is not made False anywhere. It will work anyways.
Additionally, the event of on_motion needs to be handled properly if self.active.value is used. The last line should be WorldOverlay.on_motion(self, evt) for the event to end properly.
pieleric
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryoFeature Changes
Requires the following to be merged: