[NSRPARMA-131][feat] gui sparc: if laser interlock is triggered, also blank the beam #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the most common reason for the laser interlock to be triggered is that the user opened the SPARC ATM cover. The inside of the ATM can receive X-rays caused by the e-beam. So, to be extra safe, also blank the e-beam whenever the laser interlock is triggered.
| timeout=10.0, | ||
| level=logging.WARNING) | ||
| else: | ||
| # Reactivate the e-beam blanker, but only if it is still active (otherwise, it's a sign |
There was a problem hiding this comment.
Suggested change
| # Reactivate the e-beam blanker, but only if it is still active (otherwise, it's a sign | |
| # Unblank the e-beam blanker, but only if it is still active (otherwise, it's a sign |
There was a problem hiding this comment.
"Reactivate the e-beam blanker" is not correct, indeed. However "unblank the [...] blanker" is confusing too!
It's tricky because the blanker has 3 states: e-beam blanked, e-beam unblanked, and "auto" (= e-beam blanked if not scanning).
I'll try to find a better English wording....
| if self._ebeam_blanker and self._ebeam_blanker.value: | ||
| self._ebeam_blanker.value = self._pre_interlock_blanker | ||
| if self._pre_interlock_blanker != True: | ||
| ebeam_str = " E-beam blanker was reactivated." |
There was a problem hiding this comment.
Suggested change
| ebeam_str = " E-beam blanker was reactivated." | |
| ebeam_str = " E-beam was unblanked." |
Maybe better
nandishjpatel
approved these changes
Jan 24, 2025
tepals
approved these changes
Jan 24, 2025
| popup.show_message(wx.GetApp().main_frame, | ||
| title="Laser safety", | ||
| message=f"Laser was suspended automatically due to interlock trigger.", | ||
| message=f"Laser {ebeam_str}were suspended automatically due to interlock trigger.", |
There was a problem hiding this comment.
A minor comment, but if there is no ebeam_str the sentence should be Laser was suspended and not Laser were suspended. It's fine by me if you leave it like this, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the most common reason for the laser interlock to be triggered
is that the user opened the SPARC ATM cover. The inside of the ATM can
receive X-rays caused by the e-beam. So, to be extra safe, also blank
the e-beam whenever the laser interlock is triggered.