-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[METEOR-960] Milling Structures and Functions #3000
base: master
Are you sure you want to change the base?
[METEOR-960] Milling Structures and Functions #3000
Conversation
184e086
to
8b456cb
Compare
e0bad55
to
21a8a11
Compare
@patrickcleeve2 the old mimas code that you touched here can be removed. Can you open a separate PR to remove that code, it will make it easier to review the actual changes in this PR. |
Ok, done here: #3022 |
Thanks, I merged that PR. Can you rebase this branch and fix the naming? |
21a8a11
to
55bae58
Compare
done |
I am working on the review and will try to finish it beginning of next week. Do you have any specification for this work? The linked task does not seem to match with this PR https://delmic.atlassian.net/browse/METEOR-960 |
@tepals https://docs.google.com/document/d/1aCOzusyphgVELyrZTPAOJbSHUQNQ1JUIC-Jpg0XFuzw/edit |
561ad75
to
6cecb5a
Compare
4ed4d7a
to
893008c
Compare
893008c
to
dc45cba
Compare
dc45cba
to
99e26b2
Compare
6e30f62
to
2f37f9f
Compare
2f37f9f
to
526324f
Compare
This PR contains the new milling structures and functions, and migrates the old mimas code to separate files.