Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METEOR-960] Milling Structures and Functions #3000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

patrickcleeve2
Copy link
Contributor

@patrickcleeve2 patrickcleeve2 commented Jan 22, 2025

This PR contains the new milling structures and functions, and migrates the old mimas code to separate files.

@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch 2 times, most recently from 184e086 to 8b456cb Compare January 22, 2025 08:47
@patrickcleeve2 patrickcleeve2 marked this pull request as ready for review January 23, 2025 06:31
@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch 2 times, most recently from e0bad55 to 21a8a11 Compare January 29, 2025 11:36
@patrickcleeve2 patrickcleeve2 requested a review from tepals January 29, 2025 11:37
@tepals
Copy link
Contributor

tepals commented Jan 30, 2025

@patrickcleeve2 the old mimas code that you touched here can be removed. Can you open a separate PR to remove that code, it will make it easier to review the actual changes in this PR.

@patrickcleeve2
Copy link
Contributor Author

@patrickcleeve2 the old mimas code that you touched here can be removed. Can you open a separate PR to remove that code, it will make it easier to review the actual changes in this PR.

Ok, done here: #3022

@tepals
Copy link
Contributor

tepals commented Jan 31, 2025

@patrickcleeve2 the old mimas code that you touched here can be removed. Can you open a separate PR to remove that code, it will make it easier to review the actual changes in this PR.

Ok, done here: #3022

Thanks, I merged that PR. Can you rebase this branch and fix the naming?

@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch from 21a8a11 to 55bae58 Compare February 3, 2025 07:37
@patrickcleeve2
Copy link
Contributor Author

@patrickcleeve2 the old mimas code that you touched here can be removed. Can you open a separate PR to remove that code, it will make it easier to review the actual changes in this PR.

Ok, done here: #3022

Thanks, I merged that PR. Can you rebase this branch and fix the naming?

done

@tepals
Copy link
Contributor

tepals commented Feb 6, 2025

I am working on the review and will try to finish it beginning of next week. Do you have any specification for this work? The linked task does not seem to match with this PR https://delmic.atlassian.net/browse/METEOR-960

@patrickcleeve2
Copy link
Contributor Author

I am working on the review and will try to finish it beginning of next week. Do you have any specification for this work? The linked task does not seem to match with this PR https://delmic.atlassian.net/browse/METEOR-960

@tepals https://docs.google.com/document/d/1aCOzusyphgVELyrZTPAOJbSHUQNQ1JUIC-Jpg0XFuzw/edit

@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch from 561ad75 to 6cecb5a Compare February 10, 2025 23:06
@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch 2 times, most recently from 4ed4d7a to 893008c Compare February 12, 2025 00:09
@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch from 893008c to dc45cba Compare February 14, 2025 04:49
@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch from dc45cba to 99e26b2 Compare February 17, 2025 11:11
@patrickcleeve2 patrickcleeve2 force-pushed the meteor-960-milling-struct branch from 6e30f62 to 2f37f9f Compare February 18, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants