Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Treat warnings as errors #90

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Treat warnings as errors #90

merged 1 commit into from
Jun 21, 2021

Conversation

itowlson
Copy link
Contributor

Fortunately we had no warnings. But just in case.

@simongdavies
Copy link
Member

if we up the analysis level as in #67 then there are a ton (well about 50 😃 ) of warnings but we should turn this on, I will go and fix up everything in #67 later today.

@simongdavies simongdavies mentioned this pull request Jun 21, 2021
Merged
@itowlson
Copy link
Contributor Author

@simongdavies Yeah, code analysis is a whole new world. I was thinking we should approach that gradually or we are going to end up with dozens of (mostly spurious) warnings - but definitely worth bringing on key rules.

@itowlson itowlson merged commit d613011 into deislabs:main Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bacongobbler bacongobbler bacongobbler approved these changes

@simongdavies simongdavies simongdavies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itowlson @simongdavies @bacongobbler