This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
The one true data model #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
approved these changes
Jun 7, 2021
That's fine. We need to regenerate the migrations once we add back postgresql support. The in-memory database doesn't care about database migrations so it's fine to leave that for now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrote a design doc to clarify the data model as we understood it. However the existing object model didn't quite line up with this design. This PR reworks the model to be (closer to) what we intended.
This PR includes no new UI (except changing some text fields to drop-downs) or functionality. Therefore, it treats all channels as locked to a specific revision (although it defines placeholder fields to define the channel mode and to hold auto deploy rules). Once we have the data model in place, the next step will be to tackle UI and logic for rules-based channels. This PR limits itself to the data model.
The PR also seeds multiple revisions of the Hello World app that all exist in the Deis Labs Bindle server, and two channels instead of one. This facilitates testing the channel revision update behaviour.
NOTE: This PR doesn't touch the migrations. Those will need to be revisited once the schema is firmly nailed down.