Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Document the intended design and data model #47

Merged
merged 1 commit into from
May 31, 2021
Merged

Document the intended design and data model #47

merged 1 commit into from
May 31, 2021

Conversation

itowlson
Copy link
Contributor

Per discussion with @bacongobbler on the channel model.

@itowlson itowlson requested a review from bacongobbler May 28, 2021 00:39
The various versions of an application are stored as bindles. A bindle associated with
an application is called a _revision_. Revisions don't do anything in themselves -
they just record that Hippo knows about the bindle and which application is belongs to.
**NOTE: We're not sure if this is what revisions model in the existing code - may need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out:

https://github.com/deislabs/hippo/blob/main/Hippo/Models/Application.cs#L26

https://github.com/deislabs/hippo/blob/main/Hippo/Models/Release.cs

Right now we call it a "Release" rather than a "Revision", but I think "Revision" better suits the model we're going after. So perhaps we should change the class name to match. Because it's not actually "released" until a channel selects it.

As we discussed earlier, the Revision field in the Release object is just duplicated data that we can probably infer from the bindle reference URL.

of an application, but you can use them for any situation where you want to have
different versions or different configurations.

> The weather application might have channel's named `development` (for work in progress),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channels*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg no curls up into a ball of failure and refuses to come out until summer

different versions or different configurations.

> The weather application might have channel's named `development` (for work in progress),
> `staging` (for pre-production testing) and `production` (for the live site).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a comma after "testing)" to note that "production" is a separate line item.

@itowlson itowlson merged commit aa55041 into deislabs:main May 31, 2021
@bacongobbler bacongobbler deleted the design-docs branch May 31, 2021 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants