This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
fix CreateChannelCommand #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API should be accepting a Certificate ID rather than a concrete object type. Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
Now the logic is less strict. A CertificateBindEvent will emit when the value is not null. A CertificateUnbindEvent will emit when the current value is changing to a different value. Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API should be accepting a Certificate ID rather than a concrete object type.
I also refactored some of the DomainEvents such that the code remains a little more DRY.
This was discovered while integrating hippo-openapi into hippo-cli via deislabs/hippo-cli#99. This is a breaking change to the API and will require the clients to be regenerated.
Signed-off-by: Matthew Fisher matt.fisher@fermyon.com