Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

break out into Core, Application, Infrastructure, and Web #311

Merged
merged 8 commits into from
Dec 14, 2021
Merged

break out into Core, Application, Infrastructure, and Web #311

merged 8 commits into from
Dec 14, 2021

Conversation

bacongobbler
Copy link
Contributor

@bacongobbler bacongobbler commented Dec 3, 2021 •
edited
Loading

Following DDD (Domain-Driven Design) practices as described in https://github.com/jasontaylordev/CleanArchitecture

@bacongobbler
Copy link
Contributor Author

bacongobbler commented Dec 4, 2021 •
edited
Loading

Things TODO:

  • restore Web UI
  • restore JobScheduler
  • restore ReverseProxy
  • write Infrastructure.IntegrationTests
  • restore account registration
  • check and update all channels' ActiveRevision in a RevisionCreatedEventHandler
  • require logging in before accessing a resource
  • test against hippo for compatibility
  • fix ApiController routing
  • reintroduce JWT auth for the API
  • fix scheduler domain events
  • attach domains to channels again

@bacongobbler bacongobbler force-pushed the clean-architecture branch 3 times, most recently from 7a6ab5b to 070e4d8 Compare December 4, 2021 19:21
@bacongobbler bacongobbler changed the title WIP: CleanArchitecture WIP: break out into Core, Application, Infrastructure, and Web Dec 4, 2021
@bacongobbler bacongobbler added API Issues or pull requests that affect the API enhancement New feature or request refactor Identifies code that needs to be refactored labels Dec 4, 2021
This was linked to issues Dec 9, 2021
Use DTOs instead of Models in Controllers/Views #310
Closed
implement Hippo.FunctionalTests #289
Closed
implement Hippo.IntegrationTests #290
Closed
GET Values from Configuration rather than directly from env vars #204
Closed
@bacongobbler bacongobbler changed the title WIP: break out into Core, Application, Infrastructure, and Web break out into Core, Application, Infrastructure, and Web Dec 10, 2021
@bacongobbler bacongobbler linked an issue Dec 10, 2021 that may be closed by this pull request
[ui] no error provided when login fails #221
Closed
@bacongobbler bacongobbler mentioned this pull request Dec 10, 2021
Closed
@bacongobbler bacongobbler force-pushed the clean-architecture branch 2 times, most recently from ec12c7d to c84a716 Compare December 10, 2021 22:42
@bacongobbler
break into Core, Application, Infrastructure, Web
c84a716 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler bacongobbler mentioned this pull request Dec 10, 2021
Merged
@bacongobbler
fix route conflicts
f5cb7fc 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler
put API controllers in "API" area
276c1f1 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler
Copy link
Contributor Author

Hmm... Looks like the Hippo CLI sends a response like this with hippo push:

{
"appId": null,
"bindleStorageId": "toast-on-demand",
"revisionNumber": "0.4.0"
}

Will have to look into that.

@bacongobbler
hippo push now works
e01291d 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler
fix revision created event handler
5b860e2 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler
JWT auth working again
24864b2 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
This was referenced Dec 13, 2021
Open
Open
@bacongobbler
re-introduce createtoken for backwards compatibility
be16bc6 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler
model refactors/break out into separate controllers
e4a355c 
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler bacongobbler merged commit 3258789 into deislabs:main Dec 14, 2021
@bacongobbler bacongobbler deleted the clean-architecture branch December 14, 2021 07:28
This was referenced Dec 14, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
API Issues or pull requests that affect the API enhancement New feature or request refactor Identifies code that needs to be refactored
Projects
None yet
Milestone
No milestone
1 participant
@bacongobbler