This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
chore(*): bump spin and update usage #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
itowlson
approved these changes
Mar 7, 2023
| @@ -18,7 +18,7 @@ ARG BINDLE_VERSION="v0.8.0" | |||
| RUN curl -fsSLo bindle.tar.gz https://bindle.blob.core.windows.net/releases/bindle-${BINDLE_VERSION}-linux-amd64.tar.gz && tar -xvf bindle.tar.gz && mv bindle bindle-server /usr/local/bin/ | |||
|
|
|||
| # Install spin | |||
| ARG SPIN_VERSION="v0.2.0" | |||
| ARG SPIN_VERSION="v0.10.0" | |||
There was a problem hiding this comment.
Yikes. That's quite a bump!
|
Actually wait... does the Platform use the Fermyon fork of Hippo? |
|
Nope, if this is what Installer uses then this is what we should update. Sorry for confusing the issue! |
|
Love how Spin 0.10.1 came out like 2 hours after this got merged sigh |
|
😂 I'll issue a follow-up. Haven't cut a release here so might as well! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--follow-alloption forspin upis no longer valid; the behavior of that flag is now default (see linked release notes).See also fermyon/installer#126