This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Event history #134
Merged
Event history #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
approved these changes
Jul 12, 2021
| // order, or whatever you feel is aesthetically important. The values are | ||
| // a CONTRACT. If you change them YOU WILL BREAK EVENT LOGGING. | ||
|
|
||
| AccountCreated = 0, |
There was a problem hiding this comment.
Do we want an event log when objects are deleted?
Say three users and a bot account are collaborating on an app, and the bot account removes the app. Do we want to log that event?
There was a problem hiding this comment.
We will do, but we don't have that feature yet.
Merged
|
This is a wonderful addition, thanks @itowlson
I can work on polishing this today, to try and get as much as possible polished up and ready for the demo |
flynnduism
reviewed
Jul 12, 2021
Hippo/Views/App/Details.cshtml
Outdated
| <td>@string.Join(", ", item.ActiveOn().Select(c => c.Name))</td> | ||
| </tr> | ||
| } | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <div class="row" style="padding-bottom: 20px; padding-top: 20px;"> | ||
| <h3>The Haps</h3> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an append-only persistent log of events, and a table for viewing recent events for an application.
The work is not complete at this stage: I am putting out a draft early so that we can discuss it before I spend more time on it.
(Per @bacongobbler I am also completely happy with the "ship it and noodle on it once it's out there" approach.)
TODO: once we agree on what we want the schema to look like, we need to generate migrations before we merge!
Fixes #131