Surface WAGI logs through .NET logger #116

itowlson · 2021-07-05T03:10:09Z

Fixes #72

simongdavies · 2021-07-05T10:58:48Z

Hippo/Schedulers/WagiLocalJobScheduler.cs

+                        ForwardLogs(process.StandardOutput, $"{c.Application.Name}:{c.Name}:wagi:stdout", LogLevel.Trace),
+                        ForwardLogs(process.StandardError, $"{c.Application.Name}:{c.Name}:wagi:stderr")
+                    );
+                    _wagiProcessIds[c.Id] = (process.Id, log);


Wonder if its worth logging the process exit code here?

We can log it in the Exited handler though I'm not sure how meaningful it will be - I think Rust always returns exit code 1 if an error escapes from main, and the only other reason would be forced termination. Can't hurt though - I've raised an issue for it.

itowlson requested review from bacongobbler and simongdavies July 5, 2021 03:10

simongdavies approved these changes Jul 5, 2021

View reviewed changes

Surface WAGI logs through .NET logger

891d174

itowlson merged commit 944b16d into deislabs:main Jul 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Surface WAGI logs through .NET logger #116

Surface WAGI logs through .NET logger #116

itowlson commented Jul 5, 2021

simongdavies Jul 5, 2021

itowlson Jul 5, 2021

Surface WAGI logs through .NET logger #116

Surface WAGI logs through .NET logger #116

Conversation

itowlson commented Jul 5, 2021

simongdavies Jul 5, 2021

Choose a reason for hiding this comment

itowlson Jul 5, 2021

Choose a reason for hiding this comment