This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
bug: ensure login component only requires 6 character password minimum #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
bacongobbler
approved these changes
Aug 12, 2022
bacongobbler
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency in hippo on the minimum required password length. While the hippo server login component currently requires a minimum password length of 8, the CreateAccoundCommandValidator and register components are checking for a min of 6 chars.
This makes them all consistent by having the login form also only require 6.
fixes #1090
Signed-off-by: Kate Goldenring kate.goldenring@fermyon.com