Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

UI updates to the /Account and /App sections #105

Closed
wants to merge 19 commits into from

Conversation

flynnduism
Copy link
Member

@flynnduism flynnduism commented Jun 25, 2021

This PR replaces #95, using the new grid + style elements to update these templates:

Account/Login
Account/Register
App/Index
App/New

Most notably, these changes change the flow of the UI to force more of a distinct path between Login, Dashboard and Application views. The suggestions from @bacongobbler here have been put to use, to conditionally show menus and app information as you move into the UI, hiding them until needed.

Screenshots:

Screen Shot 2021-06-25 at 8 27 25 AM

Screen Shot 2021-06-25 at 8 27 21 AM

Screen Shot 2021-06-25 at 8 27 34 AM

Screen Shot 2021-06-25 at 8 27 44 AM

Screen Shot 2021-06-25 at 8 27 37 AM


Addresses this card. More to follow in another PR, to work through the other App views pertaining to Revisions and Channels.

this adds an /assets directory with hippo.scss styles, and vendor
packages to generate the assets for the interface. i used yarn/npm
here over bower, to fetch deps and build them (npm run styles) without
the need for additional grunt/gulp/webpack layers

Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
this pr was failing due to how HomeController was setup, I had a poorly
formatted redirect that this commit fixes. additionally, this commit
makes a correction to the package.json

Signed-off-by: flynnduism <dev@ronan.design>
@carolynvs
Copy link

This looks really good! 💯

Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just looks like one piece of functionality is missing. Once that is implemented we should be good to go!

<span class="icon is-left">
<i class="fa fa-mail"></i>
</span>
<p asp-validation-for="Email" class="help is-warning"></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this new validation styling:

image

Signed-off-by: flynnduism <dev@ronan.design>
Signed-off-by: flynnduism <dev@ronan.design>
@flynnduism
Copy link
Member Author

Thanks Fisher! Updated

  • I removed HomeController - I agree I don't think we need that at this stage, there's nothing to show there.
  • Fixed the StorageId field so that form is submitting correctly.

Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase before we can merge. But this looks good to me! Feel free to merge after rebasing/CI goes green

@flynnduism
Copy link
Member Author

I’m going to close off this PR.

After a couple of messy rebases, I've chopped these edits into a new branch. There are significant UX and UI changes to how we're approaching channels & revisions (outlined in https://gist.github.com/flynnduism/53ff9b0eac93fd73be45d9ad521344e8), so I will replace this with a new PR to update the UI today.

@flynnduism flynnduism closed this Jul 9, 2021
@flynnduism flynnduism mentioned this pull request Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants