This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
page fields must be required #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the OpenAPI spec states that these objects may be optional, forcing the SDKs like Rust and typescript to generate incorrect data types, breaking backwards compatibility.
https://github.com/fermyon/hippo-openapi/blob/db10524c7cbaa8fdf853e0c4264f4589981fb50b/clients/rust/src/models/app_item_page.rs#L17
This forces the OpenAPI generator to mark these fields as required so they are not marked as nullable.