Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script may hang in 'repeatVowels' mode if there are no vowels #21

Open
zzorba opened this issue Jun 28, 2023 · 1 comment
Open

Script may hang in 'repeatVowels' mode if there are no vowels #21

zzorba opened this issue Jun 28, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@zzorba
Copy link

zzorba commented Jun 28, 2023

Just encountered this bug this morning, I introduced a very short string to my arb file:

"byLine": "by {name}",
"@byLine": {
  "placeholders": {
    "name": {
      "type": "String"
    }
   }
}

With text_expansion_format set to 'repeatVowels' , this resulted in the script failing to complete. Removing this line worked, as did changing the text_expansion_format to 'exclamationMarks'

Just an FYI for anyone else who encounters this strange bug someday.

@defuncart
Copy link
Owner

Thanks @zzorba for the report, probably the algorithm assumes that the text has a vowel 🙈 😅 I'll try to reproduce and fix it when I get a chance.

@defuncart defuncart added the good first issue Good for newcomers label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants