From 8ea0cbc8ef6b6e122df0fd3ee4019aea8a7b6408 Mon Sep 17 00:00:00 2001 From: zamaz <71521611+zachariahmiller@users.noreply.github.com> Date: Wed, 15 May 2024 20:06:05 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Wayne Starr --- chart/templates/uds-package-sandbox.yaml | 3 --- values/common-values.yaml | 4 ---- 2 files changed, 7 deletions(-) diff --git a/chart/templates/uds-package-sandbox.yaml b/chart/templates/uds-package-sandbox.yaml index b7406ca3..ede2986e 100644 --- a/chart/templates/uds-package-sandbox.yaml +++ b/chart/templates/uds-package-sandbox.yaml @@ -21,9 +21,6 @@ spec: remoteSelector: app: gitlab-runner - - direction: Egress - remoteGenerated: KubeAPI - {{- range .Values.customSandbox }} - direction: {{ .direction }} selector: diff --git a/values/common-values.yaml b/values/common-values.yaml index 54e934f1..dbbb28a5 100644 --- a/values/common-values.yaml +++ b/values/common-values.yaml @@ -6,10 +6,6 @@ rbac: create: true generatedServiceAccountName: gitlab-runner rules: - - resources: [""] - - apiGroups: [""] - resources: [""] - verbs: ["*"] - apiGroups: [""] resources: [""] verbs: [""]