Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want to add unit test for module_io/bessel_basis #2531

Closed
kirk0830 opened this issue May 26, 2023 · 3 comments
Closed

I want to add unit test for module_io/bessel_basis #2531

kirk0830 opened this issue May 26, 2023 · 3 comments
Assignees
@mohanchen

Comments

@kirk0830
Copy link
Collaborator

kirk0830 commented May 26, 2023 •
edited
Loading

Describe Current Status and Possible Solution

the unit test on module_io/bessel_basis is still lacking, I plan to add it. I will also add several doxygen-format notes for relevant functions. However, there is one variable I cannot understand well, the Ecut_number. What is the physical meaning of it?

Additional Context

No response
@kirk0830
Copy link
Collaborator Author

Get info. from @jinzx10 that Ecut_number is for determining number of spherical bessel function actually used.

@mohanchen mohanchen assigned mohanchen and unassigned caic99 Jun 4, 2023
@kirk0830 kirk0830 mentioned this issue Jun 8, 2023
Merged
@kirk0830
Copy link
Collaborator Author

kirk0830 commented Jun 8, 2023

PR #2614

@kirk0830
Copy link
Collaborator Author

kirk0830 commented Jul 3, 2023

Meet general problem discussed in issue #2666, temporarily close this one.

@kirk0830 kirk0830 closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanchen mohanchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mohanchen @kirk0830 @caic99