[Tokenizer] fix char offset #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
approved these changes
Nov 5, 2022
|
@andreabrduque FYI |
frankfliu
reviewed
Nov 5, 2022
| @@ -389,4 +389,29 @@ public void testTruncationAndPaddingForPairInputs() throws IOException { | |||
| Assert.assertEquals(encoding.getIds().length, 8); | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSpecialTokenHandling() throws IOException { | |||
There was a problem hiding this comment.
We might not need this test, the test above this already has special characters.
Codecov ReportBase: 72.08% // Head: 71.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
============================================
- Coverage 72.08% 71.40% -0.69%
- Complexity 5126 6292 +1166
============================================
Files 473 624 +151
Lines 21970 27847 +5877
Branches 2351 3004 +653
============================================
+ Hits 15838 19883 +4045
- Misses 4925 6503 +1578
- Partials 1207 1461 +254
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Uh thanks for this one. It was indeed returning UTF-8 Bytes instead of the right char spans :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed char offset issues.
fix #2112