-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add put
feature with linear indexing on PyTorch engine
#1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
============================================
- Coverage 72.08% 70.55% -1.54%
- Complexity 5126 5564 +438
============================================
Files 473 527 +54
Lines 21970 24714 +2744
Branches 2351 2680 +329
============================================
+ Hits 15838 17437 +1599
- Misses 4925 5943 +1018
- Partials 1207 1334 +127
Continue to review full report at Codecov.
|
put
feature with linear indexing on PyTorch engine
put
feature with linear indexing on PyTorch engineput
feature with linear indexing on PyTorch engine
369b65a
to
6109b3d
Compare
put
feature with linear indexing on PyTorch engineput
feature with linear indexing on PyTorch engine
Add NDIndeTest fix NDArray.get(index) testIndexationUsesSpecificManager add manager checking into PtNDArrayIndexer get(NDArray, NDIndex) Add :engines:pytorch:pytorch-jni change at::indexing to torch::indexing; testRuntimeOnly project(":engines:pytorch:pytorch-jni Restore the get(NDArray, NDIndex) Torch index type check: long, byte or boolean; restore testPick behaviour; The previous commit: PtNDManager.from() bug fixed. bug fixed bug fixed Update api/src/main/java/ai/djl/ndarray/index/dim/NDIndexNone.java Co-authored-by: Frank Liu <frankfliu2000@gmail.com> bug fixed feed std::vector<> to tensor.index(ArrayRef<>) code cleaning 2 code cleaning mixed index getter on pytorch draft
6109b3d
to
e91cfce
Compare
37a93d2
to
f52b4c9
Compare
zachgk
reviewed
Jun 29, 2022
zachgk
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
put
feature support on PyTorch engine. This corresponds totake
which get values according to linear indexing.The relavant preceding PRs
Support of take from pytorch #1627