-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Fix ImageClassification invalid probability #1575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
============================================
- Coverage 72.08% 70.85% -1.24%
- Complexity 5126 5392 +266
============================================
Files 473 503 +30
Lines 21970 23582 +1612
Branches 2351 2561 +210
============================================
+ Hits 15838 16709 +871
- Misses 4925 5594 +669
- Partials 1207 1279 +72
Continue to review full report at Codecov.
|
@@ -0,0 +1,37 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this test, we have the same test in TrainMnistTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I miss that. I will delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add check the value should be less than 1 in TrainMnistTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about the if statement Boolean.getBoolean("nightly")
. When does it become true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have continuous and nightly build, see:
https://github.com/deepjavalibrary/djl/blob/master/.github/workflows/nightly_publish.yml#L37
Change-Id: Ib6a2113f4ed669be6b5ffc4b0fdb5463b2289734
Description
examples.inference.ImageClassification
.ImageClassification