Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse default device with Device.fromName #1529

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Mar 15, 2022

This makes the names "" and null return the default device (with potentially
specified engine) instead of CPU.

This makes the names "" and null return the default device (with potentially
specified engine) instead of CPU.
@zachgk zachgk requested a review from frankfliu as a code owner March 15, 2022 16:23
@codecov-commenter
Copy link

Codecov Report

Merging #1529 (8b18f00) into master (bb5073f) will decrease coverage by 1.38%.
The diff coverage is 50.07%.

@@             Coverage Diff              @@
##             master    #1529      +/-   ##
============================================
- Coverage     72.08%   70.70%   -1.39%     
- Complexity     5126     5350     +224     
============================================
  Files           473      500      +27     
  Lines         21970    23370    +1400     
  Branches       2351     2552     +201     
============================================
+ Hits          15838    16523     +685     
- Misses         4925     5565     +640     
- Partials       1207     1282      +75     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...pi/src/main/java/ai/djl/repository/Repository.java 83.33% <ø> (ø)
...l/training/loss/SigmoidBinaryCrossEntropyLoss.java 64.00% <0.00%> (ø)
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b364e7c...8b18f00. Read the comment docs.

@zachgk zachgk merged commit fb29eda into deepjavalibrary:master Mar 15, 2022
@zachgk zachgk deleted the fromNameDefault branch March 15, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants