Clean up and add docs for BigGAN demo #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If6bfbb4989a6054934bcf6dff8ace09ec729d08a
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
============================================
+ Coverage 69.99% 70.25% +0.26%
- Complexity 5109 5170 +61
============================================
Files 504 509 +5
Lines 22613 23125 +512
Branches 2372 2431 +59
============================================
+ Hits 15828 16247 +419
- Misses 5518 5571 +53
- Partials 1267 1307 +40
Continue to review full report at Codecov.
|
frankfliu
approved these changes
Jun 18, 2021
c9b46cf to
0cec711
Compare
|
Let's put the images in our resources s3 bucket. |
6e052e9 to
d57fbbf
Compare
frankfliu
reviewed
Jun 21, 2021
examples/docs/biggan.md
Outdated
|
|
||
| Black Swan | Golden Retriever | Bubble | Alp | Cheeseburger | ||
| :-------------------------:|:-------------------------: |:-------------------------: | :----------------------: | :----------------------: | ||
|  | |  |  |  |
There was a problem hiding this comment.
use https://resources.djl.ai/images/... url
d57fbbf to
6c076c6
Compare
zachgk
reviewed
Jun 22, 2021
| @@ -181,6 +181,9 @@ public int hashCode() { | |||
| * String}>. | |||
| */ | |||
| Application WORD_RECOGNITION = new Application("cv/word_recognition"); | |||
|
|
|||
| /** An application that accepts a seed and returns generated images. */ | |||
| Application GAN = new Application("cv/gan"); | |||
There was a problem hiding this comment.
Maybe use Generator instead. A GAN is a technique and an Application is supposed to be a problem
There was a problem hiding this comment.
How about "GENERATION" to keep with the standard in Application?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all unnecessary classes from the BigGAN demo and reduced it from 5 to 3 files. I used an array as input to the translator instead of a sample-size parameter. I input the 'truncation' parameter as an argument in the criteria. Thus, the translator only needs to take an integer array of category-IDs.