Skip to content

Commit

Permalink
fix: Period Closing Voucher is considering GL entries with is_cancell…
Browse files Browse the repository at this point in the history
…ed=1 (frappe#30865)

* fix: Period Closing Voucher - Period Closing Voucher is considering GL entry with is_cancelled=1 as well

* fix: condition

Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
  • Loading branch information
SherinKR and nextchamp-saqib authored May 2, 2022
1 parent 37fad7e commit 5a5b49b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def get_pl_balances(self):
sum(t1.debit_in_account_currency) - sum(t1.credit_in_account_currency) as bal_in_account_currency,
sum(t1.debit) - sum(t1.credit) as bal_in_company_currency
from `tabGL Entry` t1, `tabAccount` t2
where t1.account = t2.name and t2.report_type = 'Profit and Loss'
where t1.is_cancelled = 0 and t1.account = t2.name and t2.report_type = 'Profit and Loss'
and t2.docstatus < 2 and t2.company = %s
and t1.posting_date between %s and %s
group by t1.account, {dimension_fields}
Expand Down

0 comments on commit 5a5b49b

Please sign in to comment.