Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable RPC integration tests one #3092 is merged. #3093

Closed
davecgh opened this issue Apr 12, 2023 · 0 comments · Fixed by #3118
Closed

Re-enable RPC integration tests one #3092 is merged. #3093

davecgh opened this issue Apr 12, 2023 · 0 comments · Fixed by #3118
Labels
reminder Issues that serve as reminders, typically for release tasks.
Milestone
1.8.0

Comments

@davecgh
Copy link
Member

davecgh commented Apr 12, 2023 •
edited
Loading

The RPC integration test framework needs to be updated to work properly with the code in #3092 and #3115.

The associated TestTreasury test in internal/integration/rpctests was disabled as a part of that PR because of the circular dependency of the separate framework requiring the code that the PR itself introduces in order to work properly with the modified version of simnet it introduces.

This is a reminder to re-enable the test once #3092 and #3115 have been merged and the separate framework has been updated to use them.

The PRs that update the RPC integration test framework are decred/dcrtest#12 and decred/dcrtest#14.
@davecgh davecgh added the reminder Issues that serve as reminders, typically for release tasks. label Apr 12, 2023
@davecgh davecgh added this to the 1.8.0 milestone Apr 12, 2023
@davecgh davecgh mentioned this issue Apr 12, 2023
Merged
@davecgh davecgh mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reminder Issues that serve as reminders, typically for release tasks.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

rpctest: Enable treasury integration test. davecgh/dcrd
1 participant
@davecgh