Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting config URL with link element in head #1132

Closed
Benaiah opened this issue Feb 23, 2018 · 6 comments
Closed

Allow setting config URL with link element in head #1132

Benaiah opened this issue Feb 23, 2018 · 6 comments

Comments

@Benaiah
Copy link
Contributor

Benaiah commented Feb 23, 2018

- Do you want to request a feature or report a bug?

feature

- What is the current behavior?

You cannot change the location or format of the config.yml - it's hardcoded to 'config.yml' (relative to the CMS location).

- What is the expected behavior?

You should be able to set the config URL by adding a <link> element to the <head> of the CMS page, as follows:

<link href="CONFIG_URL" type="CONFIG_FORMAT" rel="cms-config-url">

For now, we can require the type to be text/yaml or application/x-yaml, and continue to assume YAML format. Eventually, we could allow setting the format by setting the type attribute, and infer the format from the URL extension if there is no type set.

@Benaiah Benaiah changed the title Allow setting config URL with Allow setting config URL with link element in header Feb 23, 2018
@Benaiah Benaiah changed the title Allow setting config URL with link element in header Allow setting config URL with link element in head Feb 23, 2018
@brianlmacdonald
Copy link
Contributor

Can I give this a shot?

@Benaiah
Copy link
Contributor Author

Benaiah commented Feb 24, 2018

@brianlmacdonald absolutely - it'd be great if you could tackle this. It should be a pretty simple fix - the place where it's currently hardcoded is linked in the issue above. If you need any help feel free to ask here or on the Gitter channel - thanks for your interest!

@brianlmacdonald
Copy link
Contributor

Cool, I'll take a look at everything and circle back if I have any questions!

@talves
Copy link
Collaborator

talves commented Mar 3, 2018

@brianlmacdonald great job on #1146

@barthc
Copy link
Contributor

barthc commented Dec 12, 2018

@tomrutgers issue still valid?

@tomrutgers
Copy link
Contributor

Closing. Thanks @barthc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants