From 5e54b1a0eee8af71b8d78363cd994f9b196a0f60 Mon Sep 17 00:00:00 2001 From: Dean Blackborough Date: Mon, 4 Dec 2017 01:12:59 +0000 Subject: [PATCH 1/2] Minor corrections * Type hints missing * Unused property --- src/Bootstrap4Alert.php | 2 +- src/Bootstrap4Button.php | 4 ++-- src/Bootstrap4Card.php | 4 ++-- src/Bootstrap4Jumbotron.php | 4 ++-- src/Bootstrap4ProgressBarMultiple.php | 1 - 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/Bootstrap4Alert.php b/src/Bootstrap4Alert.php index c88ad77..b03f7d6 100644 --- a/src/Bootstrap4Alert.php +++ b/src/Bootstrap4Alert.php @@ -67,7 +67,7 @@ public function setBgStyle(string $color) : Bootstrap4Alert * * @return Bootstrap4Alert */ - public function setHeading(string $heading, $heading_level = 4) : Bootstrap4Alert + public function setHeading(string $heading, int $heading_level = 4) : Bootstrap4Alert { $this->heading = $heading; $this->heading_level = $heading_level; diff --git a/src/Bootstrap4Button.php b/src/Bootstrap4Button.php index 015932e..7e73d56 100644 --- a/src/Bootstrap4Button.php +++ b/src/Bootstrap4Button.php @@ -92,7 +92,7 @@ public function __invoke(string $label): Bootstrap4Button * * @return Bootstrap4Button */ - public function setBgStyle($color) : Bootstrap4Button + public function setBgStyle(string $color) : Bootstrap4Button { $this->assignBgStyle($color); @@ -130,7 +130,7 @@ public function setOutlineStyle(string $style): Bootstrap4Button * * @return Bootstrap4Button */ - public function setTextStyle($color) : Bootstrap4Button + public function setTextStyle(string $color) : Bootstrap4Button { $this->assignTextStyle($color); diff --git a/src/Bootstrap4Card.php b/src/Bootstrap4Card.php index 1082c8c..e8f377c 100644 --- a/src/Bootstrap4Card.php +++ b/src/Bootstrap4Card.php @@ -555,7 +555,7 @@ public function setHeader(string $content) : Bootstrap4Card * * @return Bootstrap4Card */ - public function setBgStyle($color) : Bootstrap4Card + public function setBgStyle(string $color) : Bootstrap4Card { $this->assignBgStyle($color); @@ -582,7 +582,7 @@ protected function assignBgStyle(string $color) * * @return Bootstrap4Card */ - public function setTextStyle($color) : Bootstrap4Card + public function setTextStyle(string $color) : Bootstrap4Card { $this->assignTextStyle($color); diff --git a/src/Bootstrap4Jumbotron.php b/src/Bootstrap4Jumbotron.php index f6f121a..62d84fa 100644 --- a/src/Bootstrap4Jumbotron.php +++ b/src/Bootstrap4Jumbotron.php @@ -81,7 +81,7 @@ public function fluid() : Bootstrap4Jumbotron * * @return Bootstrap4Jumbotron */ - public function setBgStyle($color) : Bootstrap4Jumbotron + public function setBgStyle(string $color) : Bootstrap4Jumbotron { $this->assignBgStyle($color); @@ -112,7 +112,7 @@ public function setHeadingDisplayLevel(int $level) : Bootstrap4Jumbotron * * @return Bootstrap4Jumbotron */ - public function setTextStyle($color) : Bootstrap4Jumbotron + public function setTextStyle(string $color) : Bootstrap4Jumbotron { $this->assignTextStyle($color); diff --git a/src/Bootstrap4ProgressBarMultiple.php b/src/Bootstrap4ProgressBarMultiple.php index 4adbbb4..3bb0508 100644 --- a/src/Bootstrap4ProgressBarMultiple.php +++ b/src/Bootstrap4ProgressBarMultiple.php @@ -180,7 +180,6 @@ private function reset(): void $this->bg_colors = []; $this->striped = false; $this->animate = false; - $this->label = null; $this->height = null; } From a177432b4b50a48fb76c02bce722ed10abdbcec9 Mon Sep 17 00:00:00 2001 From: Dean Blackborough Date: Mon, 4 Dec 2017 01:14:33 +0000 Subject: [PATCH 2/2] Changelog * Updated CHANGELOG --- CHANGELOG.md | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4138285..aba7be3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,32 +2,37 @@ Full changelog for Zend Framework 3 view helpers library. +## v1.01.1 - Minor corrections - 2017-12-04 + +* Type hints missing. +* Unused property. + ## v1.01.0 - Alert component - 2017-12-02 -* Added a Bootstrap 4 alert view helper -* Removed a redundant property in the button view helper -* Type hints missing -* Added missing dates in CHANGELOG +* Added a Bootstrap 4 alert view helper. +* Removed a redundant property in the button view helper. +* Type hints missing. +* Added missing dates in CHANGELOG. ## v1.00.0 - Card component (Official release) - 2017-10-13 Official v1.00.0 release, tests in place for all the Bootstrap 4 view helpers. -* Card view helper extends Bootstrap4Helper -* Card view helper supports setTextStyle() and setBgStyle() -* Added tests for card view helper -* setFooter() in card view helper broken, incorrect property being used to generated HTML -* Fixed a couple of bugs with the navbar view helper -* Added tests for the navbar view helper +* Card view helper extends Bootstrap4Helper. +* Card view helper supports setTextStyle() and setBgStyle(). +* Added tests for card view helper. +* setFooter() in card view helper broken, incorrect property being used to generated HTML. +* Fixed a couple of bugs with the navbar view helper. +* Added tests for the navbar view helper. ## v0.66.0 - Minor updates - 2017-10-11 -* Updated Bootstrap 4 jumbotron view helper, extends Bootstrap4Helper -* Updated Bootstrap 4 multiple progress bar view helper, extends Bootstrap4Helper -* Updated Bootstrap 4 badge view helper, extends Bootstrap4Helper -* Updated Bootstrap 4 button view helper, extends Bootstrap4Helper -* Added combined tests to view helpers -* Corrected README +* Updated Bootstrap 4 jumbotron view helper, extends Bootstrap4Helper. +* Updated Bootstrap 4 multiple progress bar view helper, extends Bootstrap4Helper. +* Updated Bootstrap 4 badge view helper, extends Bootstrap4Helper. +* Updated Bootstrap 4 button view helper, extends Bootstrap4Helper. +* Added combined tests to view helpers. +* Corrected README. ## v0.65.0 - Base class - 2017-10-11