diff --git a/Patterns/Observer/SpecialsSubject.cs b/Patterns/Observer/SpecialsSubject.cs index ae5e358..f99cf45 100644 --- a/Patterns/Observer/SpecialsSubject.cs +++ b/Patterns/Observer/SpecialsSubject.cs @@ -4,10 +4,10 @@ namespace Observer { public class SpecialsSubject : ISubject { - public delegate void Callback (string s); - public string SubjectState {get; set;} + public delegate void Callback(string s); + public required string SubjectState { get; set; } - private List _observers = new List(); + private readonly List _observers = []; public void Attach(IObserver observer) { diff --git a/Patterns/Proxy/Entries.cs b/Patterns/Proxy/Entries.cs index f04b3f6..d029f5f 100644 --- a/Patterns/Proxy/Entries.cs +++ b/Patterns/Proxy/Entries.cs @@ -14,7 +14,7 @@ public bool Delete(int id) { return _products.Remove(id); } - public IProductInfo Get(int id) + public IProductInfo? Get(int id) { if (!_products.ContainsKey(id)) { diff --git a/Patterns/Proxy/IEntries.cs b/Patterns/Proxy/IEntries.cs index 5d8576d..118a175 100644 --- a/Patterns/Proxy/IEntries.cs +++ b/Patterns/Proxy/IEntries.cs @@ -4,6 +4,6 @@ namespace Proxy public interface IEntries { bool Delete(int id); - IProductInfo Get(int id); + IProductInfo? Get(int id); } } diff --git a/Tests/ObserverTest.cs b/Tests/ObserverTest.cs index bd2d67f..a240ba7 100644 --- a/Tests/ObserverTest.cs +++ b/Tests/ObserverTest.cs @@ -11,11 +11,13 @@ public class ObserverShould public void UpdateObserverOnce_WhenSubjectHasSpecials() { // Arrange - var subject = new SpecialsSubject(); + var subject = new SpecialsSubject + { + SubjectState = "Footwear Sale" + }; var mockObserver = new Mock(); // Act subject.Attach(mockObserver.Object); - subject.SubjectState = "Footwear Sale"; subject.Notify(); // Assert mockObserver.Verify(observer => observer.Update(subject), Times.Once()); @@ -25,7 +27,10 @@ public void UpdateObserverOnce_WhenSubjectHasSpecials() public void NotCallUpdate_WhenObserverNotAttachedToSubject() { // Arrange - var subject = new SpecialsSubject(); + var subject = new SpecialsSubject + { + SubjectState = "Footwear Sale" + }; var mockObserver = new Mock(); // Act subject.SubjectState = "Footwear Sale";