Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in OverrideObject #49

Closed
differenceclouds opened this issue Nov 14, 2024 · 0 comments · Fixed by #60
Closed

Infinite loop in OverrideObject #49

differenceclouds opened this issue Nov 14, 2024 · 0 comments · Fixed by #60
Labels
bug Something isn't working ready In the dev branch, but not yet on master (not available as a package)

Comments

@differenceclouds
Copy link
Contributor

differenceclouds commented Nov 14, 2024

I'm getting an infinite loop with OverrideObject function in the case that it actually makes it to the end of the function. Returning "foundobject" instead of recursing seems to be the fix, but I'm not sure I totally understand the function to begin with. To reproduce:

  1. In Tiled, create a Rectangle Object.
  2. Give it a class string (perhaps not one from the type editor).
  3. Right click the object, and save it as a template. I think that is all that is required. In my case, the template had the same name as the class, and I had a few of them, but I don't think this is required for the bug.
  4. Import the class with only the Name, as you've outlined. (Unsure if filling out the class properties changes anything)
@dcronqvist dcronqvist added the bug Something isn't working label Nov 16, 2024
@dcronqvist dcronqvist linked a pull request Nov 17, 2024 that will close this issue
6 tasks
@dcronqvist dcronqvist added the ready In the dev branch, but not yet on master (not available as a package) label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready In the dev branch, but not yet on master (not available as a package)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants