This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Ensure proper incremental filtering + test for session_number #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This addresses #80 -- made a modification to the new macro to take a comparison operator since we need to filter before the
segment_sessionization_trailing_window
and after insegment_web_sessions
.Also added a test to make sure session_number does not repeat for users.
cc @joellabes
Checklist