Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Ensure proper incremental filtering + test for session_number #81

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

rjh336
Copy link
Contributor

@rjh336 rjh336 commented Feb 25, 2022

Description & motivation

This addresses #80 -- made a modification to the new macro to take a comparison operator since we need to filter before the segment_sessionization_trailing_window and after in segment_web_sessions.

Also added a test to make sure session_number does not repeat for users.

cc @joellabes

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@rjh336 rjh336 closed this Feb 27, 2022
@joellabes
Copy link
Contributor

@rjh336 did you mean to close this?

@rjh336 rjh336 reopened this Feb 27, 2022
@rjh336
Copy link
Contributor Author

rjh336 commented Feb 27, 2022

@rjh336 did you mean to close this?

@joellabes I did originally because I saw the new test failing after testing in my own project a few times but realized it was related to a different problem outside the scope of this package

@joellabes joellabes linked an issue Mar 7, 2022 that may be closed by this pull request
5 tasks
@joellabes
Copy link
Contributor

OK! this makes sense 👍 let's do it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicating session_number in incremental materializations
2 participants