Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Fix null session numbers #38

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix null session numbers #38

merged 1 commit into from
Feb 25, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Feb 25, 2020

Opening in favor of #32 (since I rebased)

@invinceyble
The left join with agg could mean that the whole expression is null, since any number + null is null.
This PR fixes that so session_number will never be null.

@clrcrl clrcrl mentioned this pull request Feb 25, 2020
@clrcrl clrcrl merged commit a6914e8 into master Feb 25, 2020
@joellabes joellabes deleted the fix/null-session-number branch February 14, 2022 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants