From b00aaa75be762fea11728fe812b31b0d8e0214fe Mon Sep 17 00:00:00 2001 From: Miles Liu Date: Thu, 15 Sep 2022 14:15:43 +0800 Subject: [PATCH] Delete the deprecated identifier macro resolves #669 --- CHANGELOG.md | 3 ++- macros/cross_db_utils/deprecated/identifier.sql | 16 ---------------- 2 files changed, 2 insertions(+), 17 deletions(-) delete mode 100644 macros/cross_db_utils/deprecated/identifier.sql diff --git a/CHANGELOG.md b/CHANGELOG.md index f086b2df..ef7b94fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ ## Under the hood - Remove deprecated table argument from unpivot ([#671](https://github.com/dbt-labs/dbt-utils/pull/671)) +- Delete the deprecated identifier macro ([#672](https://github.com/dbt-labs/dbt-utils/pull/672)) ## Fixes - Better handling of whitespaces in the star macro ([#651](https://github.com/dbt-labs/dbt-utils/pull/651)) @@ -27,7 +28,7 @@ - [@epapineau](https://github.com/epapineau) (#634) - [@courentin](https://github.com/courentin) (#651) - [@sfc-gh-ancoleman](https://github.com/sfc-gh-ancoleman) (#660) -- [@miles170](https://github.com/miles170) (#671) +- [@miles170](https://github.com/miles170) - [@emilyriederer](https://github.com/emilyriederer) # dbt-utils v0.8.6 diff --git a/macros/cross_db_utils/deprecated/identifier.sql b/macros/cross_db_utils/deprecated/identifier.sql deleted file mode 100644 index 619cb7cb..00000000 --- a/macros/cross_db_utils/deprecated/identifier.sql +++ /dev/null @@ -1,16 +0,0 @@ -{% macro identifier(value) %} - {%- set error_message = ' - Warning: the `identifier` macro is no longer supported and will be deprecated in a future release of dbt-utils. \ - Use `adapter.quote` instead. The {}.{} model triggered this warning. \ - '.format(model.package_name, model.name) -%} - {%- do exceptions.warn(error_message) -%} - {{ return(adapter.dispatch('identifier', 'dbt_utils') (value)) }} -{% endmacro %} - -{% macro default__identifier(value) -%} - "{{ value }}" -{%- endmacro %} - -{% macro bigquery__identifier(value) -%} - `{{ value }}` -{%- endmacro %}