-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross-db support for any_value() #497
Comments
@amychen1776 offhand, do you know whether other adapters support this? I'd like the |
@joellabes Are there specific ones you are curious about? I ask this because the dbt_utils package doesn't work fully for many of our community/vendor-supported adapters (to the point that some of them have made their own) |
Not specifically, just if there were high-usage ones you knew of that didn't have support.
you mean the shim packages, right? that's what I was thinking about here, was making it straightforward for them to overwrite. Thinking about it more, I'm going to make the default any_value and just have a carved out exception for Postgres. It'd be weird for the default any_value behaviour to be something that isn't any_value 😬 |
Yes, that's correct and yeah...that is odd? |
Resolved by #501 |
Describe the feature
To quote the Snowflake docs:
Grouping by is unnecessary when the column is known to be unique, and can add cost complexity. Adding any other aggregate (e.g.
min
) solves the problem (and is the only option for Postgres) but also can have a performance impact.It would be useful to be able to use
any_value
when available, and fall back tomin
when not.Describe alternatives you've considered
Using min all the time.
Additional context
The three core cloud warehouses supported by this package support any_value (Snowflake, BQ, Redshift). Postgres doesn't and would have to use min.
Who will this benefit?
Me!
Are you interested in contributing this feature?
Yes!
The text was updated successfully, but these errors were encountered: